Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: [CMake] remove cpack warning on fedora when lsb_release exists #10437

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

bc-lee
Copy link
Contributor

@bc-lee bc-lee commented Feb 1, 2023

Motivation / Problem

I'm currently using Fedora 37 and I get errors like this:

CMake Warning at cmake/InstallAndPackage.cmake:194 (message):
  Unknown LSB-based Linux distribution 'Fedora' found for packaging; can only
  pack to a txz.  Please consider creating a Pull Request to add support for
  this distribution.

So, I'd like to remove the warning. (BTW, I don't use cpack to install locally-modified openttd.)

Description

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@LordAro LordAro merged commit 12f9fbc into OpenTTD:master Feb 1, 2023
@bc-lee bc-lee deleted the feature/remove-warning-on-fedora branch February 1, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants