Fix: Restore using founder client name as company manager name #10535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubidium42
approved these changes
Mar 3, 2023
glx22
added
the
backport requested
rubidium42
pushed a commit
to rubidium42/OpenTTD
that referenced
this pull request
Mar 28, 2023
rubidium42
pushed a commit
to rubidium42/OpenTTD
that referenced
this pull request
Mar 28, 2023
rubidium42
pushed a commit
that referenced
this pull request
Mar 31, 2023
rubidium42
added
backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
In previous versions when creating new company in multiplayer founder client name was used as a company manager name. In 13.0 (after #9725 I guess) that no longer works as the network command gets rejected because it's issued as INVALID_COMPANY.
Description
Looks like wrong company was passed to NetworkSendCommand in SendNet. Afaict in all other cases _current_company happens to be the same as passed company so CMD_RENAME_PRESIDENT was the only one affected.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.
This PR touches english.txt or translations? Check the guidelinesThis PR affects the save game format? (label 'savegame upgrade')This PR affects the GS/AI API? (label 'needs review: Script API')ai_changelog.hpp, gs_changelog.hpp need updating.The compatibility wrappers (compat_*.nut) need updating.This PR affects the NewGRF API? (label 'needs review: NewGRF')newgrf_debug_data.h may need updating.PR must be added to API tracker