Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch: performance meter #1065

Closed
DorpsGek opened this issue Jul 22, 2007 · 12 comments
Closed

patch: performance meter #1065

DorpsGek opened this issue Jul 22, 2007 · 12 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

skidd13 opened the ticket and wrote:

A while ago Zojj wrote a patch to get a basic information how well his code improvements are. His patch worked only on Window$. At first I made a linux version of it. After a while Zojj assigned the patch to me. KUDr gave advice to me for the C++ conversion.

The patch can be used a FPS counter or as performance indicator.

There must be one thing checked: OS compatibility (at least Win32, Win64 and OSX)

forum topic: http://tt-forums.net/viewtopic.php?f=33&t=33121
svn rev: 10648
savegame bump: not needed

Attachments

Reported version: trunk
Operating system: Linux


This issue was imported from FlySpray: https://bugs.openttd.org/task/1065
@DorpsGek
Copy link
Member Author

TrueBrain wrote:

This patch looks flawed... you have to keep on moving around in order for it to do anything.. any ideas?


This comment was imported from FlySpray: https://bugs.openttd.org/task/1065#comment1693

@DorpsGek
Copy link
Member Author

skidd13 wrote:

Updated against trunk. Was a one liner.

svn rev: 10672

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/1065#comment1694

@DorpsGek
Copy link
Member Author

skidd13 wrote:

So here is the update.
Now it is possible to switch between real time and process time.
I splitted also the internal code from the GUI to extra files.

I wrote only the code for SDL based real time.

svn rev: 10684

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/1065#comment1707

@DorpsGek
Copy link
Member Author

skidd13 wrote:

Ok here is another update of the patch.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/1065#comment1713

@DorpsGek
Copy link
Member Author

skidd13 wrote:

And another one.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/1065#comment1716

@DorpsGek
Copy link
Member Author

skidd13 wrote:

Reverted too much from 28->29 here is the fixed version.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/1065#comment1717

@DorpsGek
Copy link
Member Author

peter1138 wrote:

What does 'TPS' stand for, anyway?

It also seems rather strange that what is essentially a performance debugging a tool (but not a very useful one) should require a GUI and quite a lot of code.


This comment was imported from FlySpray: https://bugs.openttd.org/task/1065#comment1718

@DorpsGek
Copy link
Member Author

skidd13 wrote:

TPS = Ticks Per Second
IMO the performance meter is for getting a basic impression of the current performance.
You could add a non GUI variant if you dislike the GUI.
The code has been written in such a way, because now other performance measurements could be added by using the same interface.
IIRC there are a few code parts in the source into this direction.


This comment was imported from FlySpray: https://bugs.openttd.org/task/1065#comment1720

@DorpsGek
Copy link
Member Author

DorpsGek commented Aug 7, 2007

skidd13 wrote:

I extended the performance meter with a new type (CPU cycles per code calls).
It's nearly working as expected ;). The current value isn't drawn right. But I'd like to hear comments about the concept itself.
The idea how it should be used is in town_cmd.cpp

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/1065#comment1833

@DorpsGek
Copy link
Member Author

DorpsGek commented Aug 8, 2007

skidd13 wrote:

Sry for the double post. Here is the fixed version.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/1065#comment1834

@DorpsGek
Copy link
Member Author

DorpsGek commented Aug 8, 2007

skidd13 wrote:

And another update. This fixes the memory leaks (I hope that I didn't missed any) and a few display bugs.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/1065#comment1841

@DorpsGek
Copy link
Member Author

skidd13 closed the ticket.

Reason for closing: Out of date


This comment was imported from FlySpray: https://bugs.openttd.org/task/1065

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Development

No branches or pull requests

1 participant