Fix: Support more than 256 stations/waypoints/roadstops per class. #10793
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
It was already possible to define more than 256 per class, but not possible to use them as the index used in GUI and passed through commands was limited to a byte.
Objects are handled differently, by passing a global instead of class & class index, so do not have the same issue.
Loading lots of NewGRFs could cause more than 256 specs to be defined per class. This would then wrap around in the UI and now allow use of all specs.
468 waypoints are loaded, but only 256 are visible.
Description
Change the index to be uint16_t instead of a byte. While 65536 may be reachable it's not a problematic limit currently.
Same set of NewGRFs are loading which gives 468 waypoints:
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.