Codechange: Split GetItem with GetOrCreateItem. #10952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterN
force-pushed
the
resolve-getitem-alert
branch
from
c5ca704
to
0402b4b
Compare
TrueBrain
reviewed
Jun 5, 2023
TrueBrain
reviewed
Jun 5, 2023
`IniGroup::GetItem()` returns nullptr if the item does not exist, but does not if the create parameter is set to true. Resolve CodeQL warnings with `GetOrCreateItem()` which returns a reference to the item instead.
PeterN
force-pushed
the
resolve-getitem-alert
branch
from
0402b4b
to
a437ff2
Compare
TrueBrain
approved these changes
Jun 5, 2023
mrmbernardi
pushed a commit
to mrmbernardi/OpenTTD
that referenced
this pull request
Jul 2, 2023
`IniGroup::GetItem()` returns nullptr if the item does not exist, but does not if the create parameter is set to true. Resolve CodeQL warnings with `GetOrCreateItem()` which returns a reference to the item instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
As seen in #10951,
IniGroup::GetItem()returns nullptr if the item does not exist, but does not if the create parameter is set to true.This causes a CodeQL warning as most callers need to check for nullptr, but some don't.
Description
Resolve CodeQL warnings by creating a separate
GetOrCreateItem()which returns a reference to the item instead.Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.