Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: IniGroup::GetItem() can now be const. #10966

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

PeterN
Copy link
Member

@PeterN PeterN commented Jun 6, 2023

Motivation / Problem

#10952 changed IniGroup::GetItem() in such a way that it can be marked const, but this was noted only after it was merged.

Description

Make IniGroup::GetItem() const.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@PeterN PeterN enabled auto-merge (squash) June 6, 2023 22:24
@PeterN PeterN merged commit 9fa1984 into OpenTTD:master Jun 6, 2023
18 checks passed
@PeterN PeterN deleted the getitem-const branch June 6, 2023 22:39
mrmbernardi pushed a commit to mrmbernardi/OpenTTD that referenced this pull request Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants