Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Refit in stations can fail if leading articulated part has 0 capacity #11034

Open
JGRennison opened this issue Jun 18, 2023 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@JGRennison
Copy link
Contributor

Version of OpenTTD

master

Expected result

Refit in stations works as expected

Actual result

Refitting in stations doesn't always work as expected because the cargo type of 0 capacity parts is not changed during refitting, so the test in HandleStationRefit can cause refitting to not be attempted because the 0 capacity leading part already matches the target cargo.

Steps to reproduce

See NewGRFs such as eGRVTS r188.

@2TallTyler 2TallTyler added good first issue Good for newcomers bug Something isn't working labels Jun 19, 2023
@xplusc
Copy link

xplusc commented Sep 15, 2023

Which vehicles from eGRVTS and cargos exhibit this behavior? I tested every refittable tram and multiple refittable road vehicles from eGRVTS r202 and they all worked correctly. Is this specific to eGRVTS r188?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants