Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: use std::variant instead of using bitflags in the value #11191

Merged
merged 1 commit into from
Aug 12, 2023

Conversation

TrueBrain
Copy link
Member

Motivation / Problem

While working on #11190 I found that InitializeViewport used some weird tactics to support a Vehicle viewport and a Tile viewport. Let's modernize it a bit!

Description

Use std::variant to know whether we want to see a Vehicle or a Tile. This works, as TileIndex is using StrongTypeDef and as such, is another type from VehicleID (which is just an integer).

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, game_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

Copy link
Member

@PeterN PeterN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oooh shiny modern!

@TrueBrain TrueBrain enabled auto-merge (squash) August 12, 2023 15:46
@TrueBrain TrueBrain merged commit 0238a2b into OpenTTD:master Aug 12, 2023
19 checks passed
@TrueBrain TrueBrain deleted the cleanup-viewport-variant branch January 18, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants