Codechange: Reorder some high-use structs to reduce their size.

[PeterN]

Motivation / Problem

Alignment of struct members can create gaps in structs, so that the memory required for each is larger than necessary.

Description

Manually reorder some high use structs to reduce padding:

Struct	Old size	New Size
GoodsEntry	144	136
CargoPacket	40	32

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

• The bug fix is important enough to be backported? (label: 'backport requested')
• This PR touches english.txt or translations? Check the guidelines
• This PR affects the save game format? (label 'savegame upgrade')
• This PR affects the GS/AI API? (label 'needs review: Script API')
  • ai_changelog.hpp, game_changelog.hpp need updating.
  • The compatibility wrappers (compat_*.nut) need updating.
• This PR affects the NewGRF API? (label 'needs review: NewGRF')
  • newgrf_debug_data.h may need updating.
  • PR must be added to API tracker

[TrueBrain]

Nice! And smart :D

Did we ever settle on a = 1 or a{1} as class member initializer? Can't remember what the result of the conversation was .. or if there was even a result :)

[PeterN]

I preferred {}, because you can init an array, or vector (etc.) in the same way.

GRFError sets precedent! ;)

I have other patches that do it this way too, but I seem to have not pushed them upstream yet :)