[Bug]: GS appears to be able to hang the game in Story Book

[andythenorth]

Version of OpenTTD

Local build of #11141

Expected result

No hang, or crash handling is invoked.

Actual result

Hang (spinning) for me on macOS, with 100% CPU core use, but crash handling is not triggered.

Steps to reproduce

Attached zip contains FIRS GS, FIRS grf, and savegame.

1. Open Story Book and look at "Grind: Persistent Storage - [foo]" pages.

2. Close Story Book.

3. Open GS Settings, and turn "Show Grind pages in story book" off and on again.

4. Re-open Story Book and try the "Grind: Persistent Storage - [foo]" pages again. This produces a hang (spinning) for me on macOS, with 100% CPU core use, but crash handling is not triggered.

Test GS spin.zip

-- Comments --

1. The GS does recursion without limit in some _Repr classes such as PrettyPrintTable (see repr.nut). This might be stupid.
2. It might be that too many elements are being added to the Story Book, or that Story Book is just very slow to render. I have had other cases where this hasn't crashed, but game FPS is noticeably reduced.
3. There might be just be a clown shoes error elsewhere in my GS. I'm trying to write my own debugger here, but debugging it without a debugger relies on having the right logging in place in anticipation.

[JGRennison]

The performance cost seems to mostly be in FormatString and the associated std::string back inserter

[glx22]

Your strings are 2900+ chars long, and you put more than 100 of them in this window.

[LordAro]

Even so, might be worth looking into improving performance...
2900x100 isn't that much in the grand scheme of things

[TrueBrain]

300KiB of text in a screen meant for a human to read .. pretty sure this falls outside of the reasonable bounds :)

Not disagreeing that improving performance is good, but resolving this ticket shouldn't be the goal / benchmark, imo. This is just abusing the system for unrelated things :D