Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #9642: Keep infrastructure totals when overbuilding road depots. #11229

Merged
merged 1 commit into from
Aug 27, 2023

Conversation

J0anJosep
Copy link
Contributor

Motivation / Problem

If you overbuild a road depot, the company road infrastructure details are wrong, as each time you overbuild it, 2 more trackbits are added to the company totals.

As after loading a game those stats are recomputed, the problem didn't arise sooner and old savegames don't need to be modified to fix the bug.

Description

This PR fixes the incorrect behaviour: overbuilding a road depot doesn't add or remove to company road infrastructure totals.

Limitations

None?

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, game_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@TrueBrain TrueBrain merged commit be9a690 into OpenTTD:master Aug 27, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants