Fix #11230: Group list widget layout failed, if dropdown widgets were higher than the font height. #11231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts were higher than the font height.
|
Guess my only concern would be how a baseset author is ever going to figure out they are doing something bad .. suggestions for that, by any chance? |
|
This is only a drop in the ocean of concerns a baseset author has to account for :) |
TrueBrain
approved these changes
Aug 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
#11230
Description
Our lord insisted that an ugly layout is still better than a glitchy layout:
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.