Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: [MacOS] use backtrace() instead of our custom variant #11233

Merged
merged 1 commit into from
Aug 27, 2023

Conversation

TrueBrain
Copy link
Member

Motivation / Problem

As mentioned in the comment, we only did it ourselves as we once were compatible with versions before 10.5. But that time has long gone. So let's update the code to a bit more modern approach.

Description

Remove custom backtrace code, and reuse the exact same code as Linux has been using.

Limitations

The output is slightly different, but not in a way that should be any problem to any reader.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, game_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

As mentioned in the comment, we only did it ourselves as we once
were compatible with versions before 10.5. But that time has long
gone. So let's update the code to a bit more modern approach.
@TrueBrain TrueBrain changed the title Codechange: [MacOS] use backtrace() instead of our custom version Codechange: [MacOS] use backtrace() instead of our custom variant Aug 27, 2023
@TrueBrain TrueBrain enabled auto-merge (squash) August 27, 2023 12:28
Copy link
Contributor

@glx22 glx22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming you tested it :)

@TrueBrain TrueBrain merged commit d4312c5 into OpenTTD:master Aug 27, 2023
19 checks passed
@TrueBrain TrueBrain deleted the backtrace-macos branch August 27, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants