Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: Use existing functions in GetMonthlyInfrastructureCosts. #11237

Merged
merged 1 commit into from
Aug 27, 2023

Conversation

J0anJosep
Copy link
Contributor

@J0anJosep J0anJosep commented Aug 27, 2023

Motivation / Problem

Not sure about this one, but there is some duplicate/similar code related with infrastructure that can be replaced with already existing functions.

Description

Replace some code with calls to already existing functions.

Limitations

For road infrastructure, it will call two functions that can't be inlined.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, game_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

Copy link
Member

@TrueBrain TrueBrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@glx22 glx22 merged commit 5e6b5d9 into OpenTTD:master Aug 27, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants