Change: mention in MacOS / Windows crashlog popup when files couldn't be generated #11239
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
On MacOS / Windows, you don't always see the console. As such, it might be unclear why a file doesn't exist while the dialog said it should been there.
This mostly happens when
crash.sav
causes a segfault (due to corruption as to why the crashlog is being created). This is trapped correctly, and on the console you can read it went wrong. But the file is still mentioned in the dialog. This can be confusing.Description
When a TryExcept block fails, update the filename to mention it failed. This is save, the filename is not used for any other purpose than to display the location to the user.
PS: as bonus, change the return value of MakeCrashLog a
void
, as nobody was actually monitoring the return value.Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.