Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: [CI] don't install breakpad on arm64-windows-static, as it is not supported (yet) #11242

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

TrueBrain
Copy link
Member

Motivation / Problem

Nightlies currently fail, as breakpad doesn't support Windows ARM64. Sad times.

Description

In theory we could fall back to dbghelp.dll, but honestly, I don't think there are many users of Windows ARM64 atm. So that is effort without any real possibility to test if it is functional. So currently, we just disable minidumps on Windows ARM64. The rest of the reporting still happens. Just no minidump.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, game_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@TrueBrain TrueBrain enabled auto-merge (squash) August 28, 2023 14:23
@TrueBrain TrueBrain merged commit 13b76b0 into OpenTTD:master Aug 28, 2023
19 checks passed
@TrueBrain TrueBrain deleted the ci-windows-arm64 branch August 28, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants