Change: for surveys capture more information about the OpenTTD version #11244
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
While working on #11232 @glx22 mentioned that the "newgrf_version" in decimals wasn't all that useful. And that the content-version would be more useful, but we didn't add that yet.
While looking into that, I also noticed we don't even tell when a version was tagged, or which exact hash it is.
Description
Address these issues all at once, and put them in a new
version
object. This means we now have all kinds of information about the OpenTTD version that was used for the survey.The
hash
is always uniquely pointing to a single commit, so good to deduplicate onThe
revision
is the human-readable variant ofhash
.The
tagged
andmodified
tells us if we should trust the survey result to begin with.The
newgrf
andcontent
gives us a rough estimation what kind of client it is, if it isn't a stable release. Not the most useful piece of information of this blob, but it might be useful some day.Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.