Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: for surveys capture more information about the OpenTTD version #11244

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

TrueBrain
Copy link
Member

Motivation / Problem

While working on #11232 @glx22 mentioned that the "newgrf_version" in decimals wasn't all that useful. And that the content-version would be more useful, but we didn't add that yet.

While looking into that, I also noticed we don't even tell when a version was tagged, or which exact hash it is.

Description

Address these issues all at once, and put them in a new version object. This means we now have all kinds of information about the OpenTTD version that was used for the survey.

The hash is always uniquely pointing to a single commit, so good to deduplicate on
The revision is the human-readable variant of hash.
The tagged and modified tells us if we should trust the survey result to begin with.
The newgrf and content gives us a rough estimation what kind of client it is, if it isn't a stable release. Not the most useful piece of information of this blob, but it might be useful some day.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, game_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@TrueBrain TrueBrain enabled auto-merge (squash) August 30, 2023 08:53
@TrueBrain TrueBrain merged commit ecb4bb5 into OpenTTD:master Aug 30, 2023
19 checks passed
@TrueBrain TrueBrain deleted the survey-version branch January 18, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants