Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: [Emscripten] remove "relative_mode" parameter from -vsdl as it doesn't exist #11249

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

TrueBrain
Copy link
Member

Motivation / Problem

At the introduction of emscripten ( d15dc9f ) this parameter was set. But I can't find any evidence it was ever implemented.

Description

I suspect during the development of that commit it did exist, but got removed in favour of #ifdef. And then got lost in time. Anyway, we don't deal with relative mode anymore in the global sense, so forget about it.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, game_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@TrueBrain TrueBrain enabled auto-merge (squash) August 31, 2023 08:17
@TrueBrain TrueBrain added the preview This PR is receiving preview builds label Aug 31, 2023
Copy link
Contributor

@glx22 glx22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't find trace of it either

@TrueBrain TrueBrain merged commit 75d3dc0 into OpenTTD:master Aug 31, 2023
20 checks passed
@TrueBrain TrueBrain deleted the em-sdl-param branch January 18, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview This PR is receiving preview builds
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants