Codechange: add tests for GS <-> AdminPort JSON conversion #11252
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
In #11251 I want to change our custom JSON conversions to nlohmann. But to know I did a good job, I first need tests.
Description
Of course during the writing of the tests you find small errors. Fixed one in #11250, and in this PR I fix another one: when loading in JSON, booleans were converted to integers. No biggy, as in Squirrel those two are interchangeable for most part.
There is one bug remaining that the tests detected in the current implementation: when loading JSON it fails to load in an empty table. This will be addressed when converting to nlohmann.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.