Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: Remove FONT_HEIGHT_... macros. #11481

Merged
merged 1 commit into from Nov 21, 2023

Conversation

PeterN
Copy link
Member

@PeterN PeterN commented Nov 21, 2023

Motivation / Problem

FONT_HEIGHT_... macros make it look like we're dealing with a constant, but actually each is a call to GetCharacterHeight(...).

Description

Use highly advanced modern global search and replaces tool to expand the macros.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, game_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

These make it look like we're dealing with a constant, but actually each is a call to `GetCharacterHeight(...)`.
Copy link
Member

@2TallTyler 2TallTyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bye macros

@PeterN PeterN merged commit c18a149 into OpenTTD:master Nov 21, 2023
19 checks passed
@PeterN PeterN deleted the font-height-macro branch November 21, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants