Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: compile-time validate the string format of IConsolePrint #11804

Merged
merged 1 commit into from Jan 16, 2024

Conversation

TrueBrain
Copy link
Member

Motivation / Problem

While working on #11800, found out that IConsolePrint isn't all that nice. It doesn't check the format of the string.

Description

Address that issue, and make it C++20 compatible.

This also means we can no longer use runtime picking what string to use.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, game_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

src/console_func.h Outdated Show resolved Hide resolved
This means we can no longer use runtime picking what string to use.
src/console_func.h Dismissed Show dismissed Hide dismissed
@TrueBrain TrueBrain merged commit 0b7410d into OpenTTD:master Jan 16, 2024
20 checks passed
@TrueBrain TrueBrain deleted the type-check-iconsoleprint branch January 18, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants