Codechange: compile-time validate the string format of IConsolePrint #11804
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
While working on #11800, found out that
IConsolePrint
isn't all that nice. It doesn't check the format of the string.Description
Address that issue, and make it C++20 compatible.
This also means we can no longer use runtime picking what string to use.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.