Codechange: remove all u8 prefix in favour of compile-time option #11807
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Every time we try C++20, we are greeted with the issue that
u8
literal is a bit .. weird, and not backwards compatible with C++17.Now @frosch123 was like: why not set a compiler-flag and remove the
u8
.As that cleans up a lot of special chars in our codebase, that sounds like an excellent plan.
Description
Remove the use of the
u8
literal, and add compiler-flags to read the strings as UTF-8 strings.Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.