Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: remove all u8 prefix in favour of compile-time option #11807

Merged
merged 1 commit into from Jan 16, 2024

Conversation

TrueBrain
Copy link
Member

Motivation / Problem

Every time we try C++20, we are greeted with the issue that u8 literal is a bit .. weird, and not backwards compatible with C++17.

Now @frosch123 was like: why not set a compiler-flag and remove the u8.

As that cleans up a lot of special chars in our codebase, that sounds like an excellent plan.

Description

Remove the use of the u8 literal, and add compiler-flags to read the strings as UTF-8 strings.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, game_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@TrueBrain TrueBrain enabled auto-merge (squash) January 16, 2024 21:00
@TrueBrain TrueBrain merged commit 6860a86 into OpenTTD:master Jan 16, 2024
19 checks passed
@TrueBrain TrueBrain deleted the remove-u8 branch January 18, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants