Remove: rdtsc and TIC/TOC based on CPU ticks #11856
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Looking over warnings from our CI / Release Job, I keep noticing it warns in some cases that there is no good RDTSC found. But, you need to know, RDTSC is only ever used during development, when adding
TIC/TOC
statements.Further more, for a long time now we have a
TICC/TOCC
alternative, which usesstd::chrono
. It is not as precise as the RDTSC can be, but I think most of us have been usingTICC/TOCC
overTIC/TOC
, as reporting inms
is much more natural than reports in some arbitrary unit.Description
Remove RDTSC code, and rename
TICC/TOCC
toTIC/TOC
(which is based onstd::chrono
).This has no impact on the user. This is only relevant for developers.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.