Codechange: [CI] use "cargo install --locked" to use pinned dependency versions #12243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y versions Normally "cargo install" will use the latest dependencies, but this causes an issue with "dump_syms". Use "--locked" makes sure we use the dependency versions as indicated by "dump_syms", instead of the latest version.
|
Releases build as expected now: |
TrueBrain
added
the
backport requested
|
What are the build issues, ooi? |
LordAro
approved these changes
Mar 9, 2024
Kuhnovic
pushed a commit
to Kuhnovic/OpenTTD
that referenced
this pull request
Mar 9, 2024
…y versions (OpenTTD#12243) Normally "cargo install" will use the latest dependencies, but this causes an issue with "dump_syms". Use "--locked" makes sure we use the dependency versions as indicated by "dump_syms", instead of the latest version.
michicc
pushed a commit
to Kuhnovic/OpenTTD
that referenced
this pull request
Mar 9, 2024
…y versions (OpenTTD#12243) Normally "cargo install" will use the latest dependencies, but this causes an issue with "dump_syms". Use "--locked" makes sure we use the dependency versions as indicated by "dump_syms", instead of the latest version.
Kuhnovic
pushed a commit
that referenced
this pull request
Mar 11, 2024
…y versions (#12243) Normally "cargo install" will use the latest dependencies, but this causes an issue with "dump_syms". Use "--locked" makes sure we use the dependency versions as indicated by "dump_syms", instead of the latest version.
Kuhnovic
added
backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
"cargo install dump_syms" fails to compile, causing release build failures if dump_syms is no longer available in our local cache.
Description
Normally "cargo install" will use the latest dependencies, but this causes an issue with "dump_syms". Use "--locked" makes sure we use the dependency versions as indicated by "dump_syms", instead of the latest version.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.