Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: Replace currency macros with functions. #12396

Merged
merged 1 commit into from Mar 29, 2024

Conversation

PeterN
Copy link
Member

@PeterN PeterN commented Mar 29, 2024

Motivation / Problem

currency.h contains a pair of macros prefixed with XXX small hack, to simplify getting the current or custom currency from the currency array.

But, macros.

Description

Replace macros with inline functions to do the same thing.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, game_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@PeterN PeterN merged commit 8d312b3 into OpenTTD:master Mar 29, 2024
15 checks passed
@PeterN PeterN deleted the remove-currency-macros branch March 29, 2024 14:49
zacc pushed a commit to zacc/OpenTTD that referenced this pull request Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants