Codechange: Move dropdown and slider out of widgets directory. #12403
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Source and headers for dropdowns and sliders are stored in the
src/widgets/
directory, however all other widget code is in the mainsrc/
directory.src/widgets/
is otherwise only used for WidgetID enums.These two uses are quite distinct and that they use the same subdirectory is unintuitive.
Description
Move dropdown and slider files out of
src/widgets/
intosrc/
. This leaves the widgets directory solely for defining Widget IDs.Also shuffle some headers to place widget includes near end.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.