Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: Move dropdown and slider out of widgets directory. #12403

Merged
merged 1 commit into from Mar 31, 2024

Conversation

PeterN
Copy link
Member

@PeterN PeterN commented Mar 31, 2024

Motivation / Problem

Source and headers for dropdowns and sliders are stored in the src/widgets/ directory, however all other widget code is in the main src/ directory.

src/widgets/ is otherwise only used for WidgetID enums.

These two uses are quite distinct and that they use the same subdirectory is unintuitive.

Description

Move dropdown and slider files out of src/widgets/ into src/. This leaves the widgets directory solely for defining Widget IDs.

Also shuffle some headers to place widget includes near end.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, game_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

Also shuffle headers to place widget includes near end.

This leaves the widgets directory solely for defining Widget IDs.
@PeterN PeterN merged commit d683ec0 into OpenTTD:master Mar 31, 2024
14 checks passed
@PeterN PeterN deleted the dropdown-slider-move branch March 31, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants