Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: Remove per font AA settings. #12413

Merged
merged 1 commit into from Apr 15, 2024
Merged

Conversation

ladysadie
Copy link
Contributor

OpenTTD will use the global AA font setting for all fonts from now on.

Motivation / Problem

Description

Console font command allow users to change aa settings per font while the settings UI only allows AA to be enabled/disabled globally.

This change will resolve that inconsistency by removing the per font aa settings and amending the font console command. The font console command was expanded with an option to toggle AA globally. AA state is now consistent across the UI and console output.

Limitations

There's a check to see if the current blitter supports AA. It's not obvious to me when the blitter would be in a state where that would fail. That's not a new quirk though.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, game_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@PeterN
Copy link
Member

PeterN commented Apr 4, 2024

I don't think the font command needs to know about the global antialiasing setting, as the toggle in Game Options window is enough. IMHO.

@PeterN
Copy link
Member

PeterN commented Apr 10, 2024

Can you please squash these two commits together?

It does not make sense to add the global AA toggle in one commit and then remove it in the next.

@ladysadie ladysadie closed this Apr 13, 2024
@ladysadie ladysadie reopened this Apr 13, 2024
OpenTTD will use the global AA font setting for all fonts from now on.
@glx22 glx22 merged commit 727392e into OpenTTD:master Apr 15, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants