Change: Display more useful information in sprite aligner than sprite ID. #12439
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Sprite IDs are not useful information given they change don't refer to anything outside the loaded game.
They may give (and has given) the false impression that Action A can be used with these IDs, when in fact anything outside of the original baseset is dynamic.
It also isn't very useful to terms of finding out where each sprite is within its file.
Description
Instead of showing the internal SpriteID, include the filename and nfo line at minimum, and include action A or action 5 sprite replacement information if applicable.
This splits of Action5Type information so that it is available to
newgrf_debug_gui.cpp
as well asnewgrf.cpp
-- this avoids duplicating the information (which my first version did...)Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.