Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: Use std::filesystem::remove/rename in settingsgen. #12483

Merged
merged 1 commit into from Apr 12, 2024

Conversation

PeterN
Copy link
Member

@PeterN PeterN commented Apr 12, 2024

Motivation / Problem

Use of unlink/rename in settingsgen.cpp which requires system-type includes.

Description

Use std::filesystem::remove/std::filesystem::rename instead.

std::filesystem::rename specifies that renaming to an existing file will replace it, so an additional remove for Windows is not necessary.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, game_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

Copy link
Contributor

@rubidium42 rubidium42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With or without failing for being unable to remove the temporary file, it's fine by me.

src/settingsgen/settingsgen.cpp Show resolved Hide resolved
@PeterN PeterN merged commit ca73f03 into OpenTTD:master Apr 12, 2024
14 checks passed
@PeterN PeterN deleted the settingsgen-filesystem branch April 12, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants