Codechange: Use std::filesystem::remove/rename in settingsgen. #12483
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Use of
unlink
/rename
in settingsgen.cpp which requires system-type includes.Description
Use
std::filesystem::remove
/std::filesystem::rename
instead.std::filesystem::rename
specifies that renaming to an existing file will replace it, so an additional remove for Windows is not necessary.Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.