Codechange: Introduce FioRemove() to remove files. #12491
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
unlink
is used in various places, but depending on platform, might actually be a macro to_wfunlink
withOTTD2FS
being called too.Description
New function FioRemove() handles OTTD2FS conversion (which already does nothing on platforms that don't need it), and uses std::filesystem::remove instead of unlink, all in one location.
Limitations
Adds a debug message which is perhaps not necessary.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.