Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: Introduce FioRemove() to remove files. #12491

Merged
merged 1 commit into from Apr 14, 2024

Conversation

PeterN
Copy link
Member

@PeterN PeterN commented Apr 13, 2024

Motivation / Problem

unlink is used in various places, but depending on platform, might actually be a macro to _wfunlink with OTTD2FS being called too.

Description

New function FioRemove() handles OTTD2FS conversion (which already does nothing on platforms that don't need it), and uses std::filesystem::remove instead of unlink, all in one location.

Limitations

Adds a debug message which is perhaps not necessary.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, game_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

New function FioRemove() handles OTTD2FS conversion, and uses std::filesystem::remove instead of unlink, all in one location.
@PeterN PeterN merged commit 4eaeccd into OpenTTD:master Apr 14, 2024
14 checks passed
@PeterN PeterN deleted the fio-remove branch April 14, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants