Codechange: Use std::optional for town parent scope resolver. #12530
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
When resolving NewGRF, the parent town_scope is lazily initialised as it does not always need to be used.
But it uses a raw pointer so requires manual management with new/delete. Airports tried to use a unique_ptr, but still used new instead of make_unique.
Description
As TownScopeResolver is not large, replace the manually managed pointer with std::optional to simplify it.
Using std::optional also avoids extra memory allocation.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.