Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: Use string_view in IniItem/IniGroup/IniFile. #12535

Merged
merged 1 commit into from Apr 19, 2024

Conversation

PeterN
Copy link
Member

@PeterN PeterN commented Apr 19, 2024

Motivation / Problem

I'm still learning. A while back I switched the Ini file system from char * to std::string, not giving any consideration to std::string_view. However after reviewing it, I can see there are places where std::strings are constructed from char *. These temporary strings are then either thrown away, or copied again, and... thrown away.

Description

Use std::string_view in IniItem/IniGroup/IniFile. This avoids making extra copies of strings.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, game_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

This avoids making extra copies of strings.
@PeterN PeterN merged commit 6ee31a2 into OpenTTD:master Apr 19, 2024
14 checks passed
@PeterN PeterN deleted the ini-string_view branch April 19, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants