Codechange: Use string_view in IniItem/IniGroup/IniFile. #12535
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
I'm still learning. A while back I switched the Ini file system from
char *
tostd::string
, not giving any consideration tostd::string_view
. However after reviewing it, I can see there are places wherestd::string
s are constructed fromchar *
. These temporary strings are then either thrown away, or copied again, and... thrown away.Description
Use
std::string_view
in IniItem/IniGroup/IniFile. This avoids making extra copies of strings.Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.