Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: Use member initialization of GRFFilePropsBase. #12581

Merged
merged 1 commit into from Apr 26, 2024

Conversation

PeterN
Copy link
Member

@PeterN PeterN commented Apr 26, 2024

Motivation / Problem

C-array in GRFPropsBase, along with memset in the constructor to initalise it.

Description

Don't blame compilers for our sloppy initialisation.

Replace the C-array with std::array and remove the memset.

Removes memset, and lengthof.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, game_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

Don't blame compilers for our sloppy initialisation.

Removes memset, and lengthof.
@PeterN PeterN merged commit bf8de18 into OpenTTD:master Apr 26, 2024
14 checks passed
@PeterN PeterN deleted the grfpropsbase branch April 26, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants