Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Console command scrolling did not take account of padding and cursor width. #12642

Merged
merged 1 commit into from May 8, 2024

Conversation

PeterN
Copy link
Member

@PeterN PeterN commented May 7, 2024

Motivation / Problem

Console horizontal width does not take account of window padding nor cursor width, resulting in a long console command being cropped and displayed with ellipsis:

image

Description

Resolved by take account of padding width and cursor width.

image

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, game_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@PeterN PeterN added the backport requested This PR should be backport to current release (RC / stable) label May 8, 2024
@PeterN PeterN merged commit b74a7e7 into OpenTTD:master May 8, 2024
15 checks passed
@PeterN PeterN deleted the fix-long-console branch May 8, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport requested This PR should be backport to current release (RC / stable)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants