Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cost estimate always shows "Estimated Cost: £0" even if actual cost is not £0. #7764

Closed
James103 opened this issue Oct 6, 2019 · 2 comments
Closed
Labels
regression

Comments

@James103
Copy link
Contributor

@James103 James103 commented Oct 6, 2019

Version of OpenTTD

Working on 2019-08-24, broken on 2019-10-02.

Expected result

Cost estimates should give nonzero number.
Example: "Estimated Cost: £15" or "Estimated Income: £8,203".

Actual result

Cost estimate always returns zero.
Example: "Estimated Cost: £0" or "Estimated Income: £0".
Affects error message for not enough money, displaying "Not enough cash - requires £0".
Does not affect the script API (GSAccounting + GSTestMode returns nonzero results)

This could possibly be due to commits b3fd787 or 0549a81 (both dealing with command flags).

Steps to reproduce

Hold Shift while attempting to perform a game command (such as clearing land, buying or selling an engine, or doing a town action) to get the cost estimate. It will always say £0. Alternatively, attempt to perform a game command when you don't have enough money to do so. It will also say £0 in the error message.

@nielsmh nielsmh added the regression label Oct 6, 2019
@glx22
Copy link
Contributor

@glx22 glx22 commented Oct 6, 2019

I think it's already fixed by #7760

@glx22
Copy link
Contributor

@glx22 glx22 commented Oct 6, 2019

After checking the code, I can confirm it's fixed by #7760.

@glx22 glx22 closed this Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression
Projects
None yet
Development

No branches or pull requests

3 participants