Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update last servicing dates when using the date cheat #9694

Merged
merged 1 commit into from Nov 19, 2021

Conversation

nchappe
Copy link
Contributor

@nchappe nchappe commented Nov 14, 2021

Motivation / Problem

The dates of last service are not shifted after changing the current year with the cheat menu. This has several consequences, mainly if service intervals are in days and a vehicle has a service order.

  • If the cheat was used to go back in time, the date of last service may become in the future, in which case the vehicle will not service for a long time
  • If the date was advanced by n years, it adds n years to the time since last service of the vehicle (_date - date_of_last_service), so it will go to depot n years early

To reproduce this bug, create a vehicle with a service order and a servicing interval of e.g. 120 days, decrement the date by one year and observe that the vehicle waits 120 days + 1 year before going to a depot.

Description

This PR introduces a Vehicle::ShiftDates() function that works like LinkGraph::ShiftDates(). This method is called for all vehicles when the maximum year is reached (this case was already handled before) and when the cheat menu is used. This function will also be useful for #9093 and #9693.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@LordAro LordAro added the backport requested This PR should be backport to current release (RC / stable) label Nov 19, 2021
@LordAro LordAro merged commit 2cb6351 into OpenTTD:master Nov 19, 2021
TrueBrain pushed a commit to TrueBrain/OpenTTD that referenced this pull request Jan 3, 2022
@TrueBrain TrueBrain added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants