Fix: Update last servicing dates when using the date cheat #9694
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
The dates of last service are not shifted after changing the current year with the cheat menu. This has several consequences, mainly if service intervals are in days and a vehicle has a service order.
_date - date_of_last_service
), so it will go to depot n years earlyTo reproduce this bug, create a vehicle with a service order and a servicing interval of e.g. 120 days, decrement the date by one year and observe that the vehicle waits 120 days + 1 year before going to a depot.
Description
This PR introduces a
Vehicle::ShiftDates()
function that works likeLinkGraph::ShiftDates()
. This method is called for all vehicles when the maximum year is reached (this case was already handled before) and when the cheat menu is used. This function will also be useful for #9093 and #9693.Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.