Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider working around libinput's smoothing #1514

Closed
gonX opened this issue Oct 13, 2021 · 8 comments · May be fixed by #1983
Closed

Consider working around libinput's smoothing #1514

gonX opened this issue Oct 13, 2021 · 8 comments · May be fixed by #1983
Labels
enhancement New feature or request
Milestone

Comments

@gonX
Copy link
Member

gonX commented Oct 13, 2021

Description

libinput has smoothing disabled for tablets with AES pens, which means it's likely possible for OTD to fake this information in order to bypass libinput's smoothing, eliminating the need for the libinput patch that removes the smoothing (https://gitlab.freedesktop.org/libinput/libinput/-/issues/225)

The changes in libinput to detect AES pens is here:
https://gitlab.freedesktop.org/libinput/libinput/-/merge_requests/512/diffs?commit_id=a506d092b8fc5d05c0ef7579b58d36be20b2c2af

Doing this would allow us to more accurately control the input

@gonX gonX added the enhancement New feature or request label Oct 13, 2021
@InfinityGhost
Copy link
Member

What flags would we have to use to perform this? I haven't done any looking yet for myself within the docs however.

@gonX
Copy link
Member Author

gonX commented Oct 16, 2021

I have some ideas now - it appears that there is a quirks framework in libinput, and it seems to be possible to disable smoothing through that. Once I figure out how to do that I will report back.

It seems to be something that can be solved in packaging, but seemingly not in code, btw.

@gonX
Copy link
Member Author

gonX commented Oct 16, 2021

After some further investigation, it appears that setting AttrTabletSmoothing=0 in libinput quirks results in the device getting AttrTabletSmoothing=1 forced instead. It seems to be a libinput bug and might need to get reported upstream if nobody else can find an explanation.

Discord conversation: https://discord.com/channels/615607687467761684/628651971267788800/898941511574626394

@InfinityGhost
Copy link
Member

It seems to be something that can be solved in packaging, but seemingly not in code, btw.

Ouch, hope not as this could be pretty big to outright remove the need for the Artist mode.

@gonX gonX added this to the v0.7.x milestone Nov 30, 2021
@gonX
Copy link
Member Author

gonX commented Nov 30, 2021

Setting this for not-0.6.x milestone as we have Absolute Mode.

Also seems like an upstream issue that someone needs to report - I can do it when I get around to it, but I won't be offended if someone gets there before me

@gonX
Copy link
Member Author

gonX commented Jan 15, 2022

Reported upstream: libinput/libinput#725

@gonX gonX mentioned this issue Jan 18, 2022
3 tasks
@gonX
Copy link
Member Author

gonX commented Jan 18, 2022

Forgot to update here but the upstream issue was visual only. I am doing some work on making Linux Artist Mode a more suitable replacement for Absolute Mode.

@gonX
Copy link
Member Author

gonX commented Aug 22, 2023

Closing in favour of #2895

@gonX gonX closed this as completed Aug 22, 2023
@gonX gonX closed this as not planned Won't fix, can't repro, duplicate, stale Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants