Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add torque param to local #112

Closed
slifty opened this issue Apr 30, 2021 · 2 comments
Closed

Add torque param to local #112

slifty opened this issue Apr 30, 2021 · 2 comments
Assignees

Comments

@slifty
Copy link
Contributor

slifty commented Apr 30, 2021

@hawkinsw noticed that torque isn't running on his local setup and I think this is because there is a new ansible variable used by the torque setup (see the end of this commit).

To fix this up we'll just need to add a torquedata_git_version to the base/torquedata/ansible/inv/local/gorup_vars/all.tmpl

(Note that we'll also want to update OpenTechStrategies/torque-devenv to populate that variable via envsubst).

@frankduncan
Copy link
Collaborator

I'll tackle this. I think the correct solution is to actually have a default variable that should be overridden for special cases. I'll update all the files to use this default when appropriate. That's how it works for the plugin checkout for the competitions.

I should note that the default checkout will be off the postgres branch in torque, which we'll be moving to fully this week!

@slifty
Copy link
Contributor Author

slifty commented May 5, 2021

Oh great call -- I'm going to use this pattern for the simplebook version I'm about to add!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants