Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set_var expands all (minus one) passed parameters as value #799

Closed
TinCanTech opened this issue Dec 4, 2022 · 0 comments · Fixed by #811
Closed

set_var expands all (minus one) passed parameters as value #799

TinCanTech opened this issue Dec 4, 2022 · 0 comments · Fixed by #811
Assignees
@TinCanTech
Labels
Version 3.1.x

Comments

@TinCanTech
Copy link
Collaborator

TinCanTech commented Dec 4, 2022 •
edited

EG:

set_var EASYRSA_REQ_CN ChangeMe foo

Results in:

EASYRSA_REQ_CN = "ChangeMe foo"

This is a set_var() design flaw.

set_var() is ambiguous.

set_var() is only used internally, use it correctly.

set_var is used by vars file, so there is potential for mistakes ..
@TinCanTech TinCanTech self-assigned this Dec 4, 2022
@TinCanTech TinCanTech added this to the v3.1.2 - Probably milestone Dec 4, 2022
@TinCanTech TinCanTech linked a pull request Dec 5, 2022 that will close this issue
set-var(): Check input, die on errors #801
Closed
@TinCanTech TinCanTech removed this from the v3.1.2 - Probably milestone Dec 6, 2022
@TinCanTech TinCanTech linked a pull request Dec 10, 2022 that will close this issue
New function safe_set_var(): Safe wrapper for set_var() #811
Merged
@TinCanTech TinCanTech removed a link to a pull request Dec 10, 2022
set-var(): Check input, die on errors #801
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TinCanTech TinCanTech

Labels
Version 3.1.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New function safe_set_var(): Safe wrapper for set_var() TinCanTech/easy-rsa
1 participant
@TinCanTech