Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Steam VR Input bindings documentation updated for system button. #203

Closed
Viperlotus opened this issue May 20, 2019 · 5 comments · Fixed by #232
Closed

Steam VR Input bindings documentation updated for system button. #203

Viperlotus opened this issue May 20, 2019 · 5 comments · Fixed by #232
Assignees
Labels
bug Something isn't working

Comments

@Viperlotus
Copy link

Hello. A month or so ago I made a topic inquiring about using the system button of a Vive wand as a push-to-talk toggle for Advanced Settings. This topic was closed (understandably so) because at the time it was not possible to do so due to the limitations in SteamVR's binding options. However, before the topic was closed, it was pointed out that SteamVR's beta branch had added the ability to rebind the system button. I decided to wait until that change was added to the main branch of SteamVR, which happened with its latest update.

So, that leads me to today. I tried using a system button as a push-to-talk toggle like before. First I opened the bindings options for Advanced Settings and successfully set the left system button as a toggle button, then bound the click function as push-to-talk. After that, I opened the bindings options for VR Compositor and unbound all actions from the left system button so that they wouldn't interfere with the push-to-talk setting. Even after all that however, pressing the assigned system button still doesn't activate push-to-talk at all.

@username223
Copy link
Member

Do other buttons work as PTT?

Do other actions work on the system button?

I must admit that I'm not familiar with binding to the system button. The regular bindings do not work when the SteamVR overlay view is up, could that be interfering somehow?

@username223 username223 added the bug Something isn't working label May 20, 2019
@Viperlotus
Copy link
Author

Do other buttons work as PTT?

Do other actions work on the system button?

I must admit that I'm not familiar with binding to the system button. The regular bindings do not work when the SteamVR overlay view is up, could that be interfering somehow?

The answer to the first question is yes, other buttons do work as push-to-talk.

I have not yet tried binding other OVRAS actions to the system button, but obviously VR Compositor bindings do work on the system button.

And yes, I made sure to test the bindings with the SteamVR overlay view closed, to no effect.

@ykeara
Copy link
Member

ykeara commented Jun 1, 2019

OKAY figured it out.

in Steamvr.vrsettings Under Steam VR This line needs to be added "sendSystemButtonToAllApps" : true

I will submit a bug-Report because it does not feel like this should be the standard behavior.... and it is confusing.... on top of it it doesn't block the "touch" event on knuckles controllers so its just bizarre.

Changing Issue to reflect some updates on our end on documentation needed.....

@ykeara ykeara changed the title Binding push-to-talk to Vive wand system button doesn't work. Steam VR Input bindings documentation updated for system button. Jun 1, 2019
@ykeara ykeara self-assigned this Jun 1, 2019
@Viperlotus
Copy link
Author

Sorry for the late response, everyone. It took me a while to get to it, but I just tried the fix ykeara mentioned. It does work; However, there is one important caveat that he did not mention in his post.

In the file where you add the line mentioned in the fix, you absolutely must add a comma mark to the end of the line preceding it if the added line is the last one in the Steam VR section block.

Alternatively, if the added line is not placed as the last one in the Steam VR section block, then you must add a comma mark to the end of the added line.

If you don't add a comma mark where it's supposed to be in relation to the added line, the steamvr.vrsettings file won't be read by Steam VR, and the settings that file is responsible for adjusting will all be set to their default values.

@ykeara
Copy link
Member

ykeara commented Jun 11, 2019

yea you have to respect json formatting.... if its last in the list of settings it won't have common, but ones before it will have to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants