New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is this a fencepost error? #848

Open

bdezonia opened this issue Feb 24, 2024 · 0 comments

Contributor

bdezonia commented Feb 24, 2024

See this line of code:

OpenVnmrJ/src/nvpsg/solidmpseqs.h

Line 5505 in 0ad7471

if (s.pw[0] < 0.0) {

Should the if test be stated as "<= 0" instead of as "< 0"? The error message implies 0 might be a bad value but our current code is not catching it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment