Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

condition translation futile #13

Closed
emphasize opened this issue Oct 20, 2022 · 1 comment · Fixed by #19
Closed

condition translation futile #13

emphasize opened this issue Oct 20, 2022 · 1 comment · Fixed by #19

Comments

@emphasize
Copy link
Member

emphasize commented Oct 20, 2022

... in its current implementation

this may be confusing, but weather.condition.description (translated here) can be one of the listed here ("Description" section). These descriptions are already translated in the json returned from the API call. (given the correct lang code is passed)

@emphasize
Copy link
Member Author

emphasize commented Oct 21, 2022

What i will do is remove the translation of weather.condition.description, but add the missing weather categories (what is called "main" in OWM API Docs) to the locale in case we need a translation of those in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant