Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI builds to improve pull request and code quality #112

Closed
jeking3 opened this issue Mar 13, 2018 · 2 comments
Closed

Add CI builds to improve pull request and code quality #112

jeking3 opened this issue Mar 13, 2018 · 2 comments

Comments

@jeking3
Copy link
Contributor

jeking3 commented Mar 13, 2018

CI builds would run every pull request allowing code submitters to self-service and provide code that passes tests before going through a code review. It can also periodically run master and develop through builds to prove out code correctness (i.e. does it compile, link, and pass unit tests?) as well as provide code coverage and static code analysis.

You could add matrix jobs that build every combination of:

  • autoconf or cmake
  • openssl 1.0.x or 1.1.x
  • linux or osx

as well as jobs that do:

  • code coverage (integrate with codecov.io)
  • ubsan
  • coverity scan, if it ever comes back up...

etc...

@kkaempf
Copy link
Collaborator

kkaempf commented Nov 19, 2018

Respective pull requests are happily accepted.

@kkaempf kkaempf closed this as completed Nov 19, 2018
@jeking3
Copy link
Contributor Author

jeking3 commented Nov 19, 2018

Closing the issue reduces the chance someone will remember to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants