Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Success Story" basic functionality #318

Open
7 tasks
AllenAnthes opened this issue Apr 22, 2020 · 6 comments
Open
7 tasks

"Success Story" basic functionality #318

AllenAnthes opened this issue Apr 22, 2020 · 6 comments

Comments

@AllenAnthes
Copy link
Member

AllenAnthes commented Apr 22, 2020

Feature request

We would like to add the ability for registered users to post their success stories. This will likely involve

  • adding a new database table via a SuccessStory model in src/api/models.py
    • contains at least the fields for created_by (User), created_at, text, is_approved, others?
  • a serializer for the model in src/api/serializers.py
  • a view in src/api/views.py
    • only authenticated users should be able to CREATE a new success story
    • anyone should be able to read success stories (@kylemh is this correct?)
    • for the initial implementation all other interactions should be disabled (no updating, deleting, etc)
@kylemh
Copy link
Member

kylemh commented Apr 22, 2020

Yes, correct. This looks great.

@Too-Far
Copy link

Too-Far commented May 1, 2020

Hey if you guys need help with this I can work on it. It's my first time contributing so I'll apologize ahead of time for the required hand holding.

@kylemh
Copy link
Member

kylemh commented May 1, 2020

I won't have any guidance to offer, but feel free to give it a go! Ask any questions in #oc-projects-python on Slack

@Too-Far
Copy link

Too-Far commented May 1, 2020

You got it, thanks!

@Too-Far
Copy link

Too-Far commented May 3, 2020

I submitted a PR for this. I am going to need some help with the testing, I can't seem to get it to work. Also, I was thinking... should we just make a space for this in core/models/profile? It seems like that would make it easier to work with down the road. Again, I am a complete newbie so I could be completely off base...

@dumaas
Copy link

dumaas commented Dec 29, 2020

Hey all! Could I claim this issue? What was wrong with the previous PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants