-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for adding custom labels and environment variables to nodes via spec #149
Add support for adding custom labels and environment variables to nodes via spec #149
Conversation
4f61f6e
to
93d3b9a
Compare
I also added test coverage for user defined labels and env vars. |
Two comments from my side:
|
cf91967
to
dd00563
Compare
Sounds good. I've made these changes and squashed the commits. |
LGTM. If you could work in the complaint from the linter, I'll approve the PR. |
…les on nodes. Signed-off-by: jesse.millan <jesse.millan@oracle.com>
dd00563
to
52a4330
Compare
All set. |
@jlamillan Merged. Thank you for your work with this PR. Much appreciated. |
Greetings!
This pull-request resolves #135 by adding support add custom labels and environment variables to nodes via spec, which get propagated to the node deployments/pods.