Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for spec.dashboards.env #167

Merged

Conversation

ekarlso
Copy link
Contributor

@ekarlso ekarlso commented Jun 1, 2022

No description provided.

@ekarlso ekarlso force-pushed the add-dashboard-env-support branch 3 times, most recently from 3f7d8d9 to 0a41668 Compare June 2, 2022 05:33
Copy link
Collaborator

@swoehrl-mw swoehrl-mw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ekarlso. Thak you for your PR.
Just two minor things:

  • Please remove the extra print statements
  • Can you please add the new field to the CRD doc

opensearch-operator/pkg/builders/cluster.go Outdated Show resolved Hide resolved
@ekarlso ekarlso force-pushed the add-dashboard-env-support branch from 0a41668 to 92cc253 Compare June 3, 2022 18:37
Signed-off-by: Endre Karlson <endre.karlson@gmail.com>
@ekarlso ekarlso force-pushed the add-dashboard-env-support branch from 92cc253 to 5666968 Compare June 4, 2022 19:17
@swoehrl-mw swoehrl-mw merged commit d547724 into opensearch-project:main Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants