Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rate limiter (BounceBack) is not working as expected #1946

Closed
fr1sk opened this issue Dec 28, 2020 · 3 comments
Closed

Rate limiter (BounceBack) is not working as expected #1946

fr1sk opened this issue Dec 28, 2020 · 3 comments
Labels

Comments

@fr1sk
Copy link

fr1sk commented Dec 28, 2020

Main issue:

I have a simple queue that is responsible for delegating the task from the main API to the microservice. When I use bounceBack: true as a rate limiter option, the job is not added to the queue if the limit is already hit.

Reproduce:

Use those rate limiter options for any queue:

  max: 3,
  duration: 10000,
  bounceBack: false,

when bounceBack is set to false, the job is added to the delay state, which is ok. But when I set bounceBack to true, I expect that job will be in the waiting state, but the job is never added.

Bull version:

3.13.0

Additional:

Nest version: 6.11.5

@manast
Copy link
Member

manast commented Dec 29, 2020

A couple of things, first we would need a complete test case (as code that we can copy/paste and run as is) that reproduces the issue, secondly you should try to reproduce it with the latest version of Bull. Thanks.

@stale
Copy link

stale bot commented Jul 12, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jul 12, 2021
@manast manast closed this as completed Jul 15, 2021
@Drieger
Copy link

Drieger commented Oct 2, 2021

I got the same problem. And it seems related to #2082

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants