Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify in documentation which ACL rules to add to allow bull to work normally #2534

Closed
soumitradev opened this issue Jan 31, 2023 · 4 comments
Labels

Comments

@soumitradev
Copy link

By default, I exclude all ACL rules, and then I add my own ACL rules as I go for security. Now, on adding bull I have to figure out which redis commands bull uses internally so I can add them individually to my ACL config. It would be really convenient if the exact ACL rules to add were mentioned somewhere in the docs.

I'm willing to add it to the docs and to the guide, it's just that I'm not too sure if the set of ACL rules I'm using cover every use case out there. (I am using Queues, and adding jobs to the queues using a priority).

If someone knows the exact set of commands and key patterns bull uses, I'd be happy to add it to the docs and guide.

P.S. Phenomenal work on the library, I really appreciate it <3

@manast
Copy link
Member

manast commented Feb 3, 2023

I recommend you use Redis MONITOR command to see what is going on. It is not easy to gather the list of all used commands. I think it would be easier to allow the keys used by the queues than the commands...

@stale
Copy link

stale bot commented Apr 4, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 4, 2023
@stale stale bot closed this as completed Apr 11, 2023
@MartianH
Copy link

MartianH commented Apr 4, 2024

I actually second this, I am in the same boat right now. Especially since gathering a list of user commands can be done once.

@manast
Copy link
Member

manast commented Apr 4, 2024

One possibility is to run a script with a regexp that finds all the calls to redis commands in the lua scripts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants