Fix: don't reschedule delay timer if closing #2535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manast
approved these changes
Feb 3, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Feb 3, 2023
## [4.10.3](v4.10.2...v4.10.3) (2023-02-03) ### Bug Fixes * don't reschedule delay timer if closing ([#2535](#2535)) ([8a0292a](8a0292a))
|
🎉 This PR is included in version 4.10.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Awesome! Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's sometimes possible the close of bull does not correctly stop the update timer. In some circumstances the update time is stil active after the close call is finished.
Our process hangs on stopping if the timer is active. Tried multiple times with this fix, and our process always stops