Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reusing redis connection for bull v4+, outdated doc? #2720

Closed
DavideViolante opened this issue Apr 10, 2024 · 4 comments
Closed

Reusing redis connection for bull v4+, outdated doc? #2720

DavideViolante opened this issue Apr 10, 2024 · 4 comments

Comments

@DavideViolante
Copy link
Contributor

Description

Hello, I'd like to know if this doc is outdated because since bull v4 the breaking change says that these 2 redis options are now compulsory:

{
  maxRetriesPerRequest: null,
  enableReadyCheck: false
}

In the doc it just passes the REDIS_URL in the new Redis(). Does it need also the other 2 options?

Minimal, Working Test code to reproduce the issue.

(An easy to reproduce test case will dramatically decrease the resolution time.)

Bull version

4.12.2

Additional information

@manast
Copy link
Member

manast commented Apr 10, 2024

I think you may be mixing Bull and BullMQ. The options you name are compulsory in BullMQ not in Bull.

@DavideViolante
Copy link
Contributor Author

I'm quite confused. The doc I linked is bull, correct? bullmq is another repo?! The release notes and changelog are about this repo, not bullmq. The 4.0.0 breaking changes says, for bull:
If redis opts are missing: { maxRetriesPerRequest: null, enableReadyCheck: false } then a exception will be thrown.

@manast
Copy link
Member

manast commented Apr 10, 2024

Ah ok, I forgot we also backported this requirement to Bull, sorry for the oversight. Most likely we will not update the docs as we are putting all our efforts on BullMQ these days though.

@DavideViolante
Copy link
Contributor Author

I made a PR to update that file. I think it's totally safe to merge if the text is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants